Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/30068 ) Change subject: DAHDI trunkdev support ...................................................................... Patch Set 1: (3 comments) File src/dahdi_trunkdev.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-853): https://gerrit.osmocom.org/c/osmo-e1d/+/30068/comment/7bf0567f_99c02522 PS1, Line 21: * with this program; if not, write to the Free Software Foundation, Inc., Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. This Osmocom project should already include a copy of the (A)GPL. Robot Comment from checkpatch (run ID jenkins-gerrit-lint-853): https://gerrit.osmocom.org/c/osmo-e1d/+/30068/comment/2227239d_d8d1ec3a PS1, Line 22: * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. This Osmocom project should already include a copy of the (A)GPL. Robot Comment from checkpatch (run ID jenkins-gerrit-lint-853): https://gerrit.osmocom.org/c/osmo-e1d/+/30068/comment/ab1e91f8_f93725c3 PS1, Line 51: strncpy(td_o.name, name, sizeof(td_o.name)); Instead of strncpy()/strcpy(), use osmo_strlcpy() or OSMO_STRLCPY_ARRAY() -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/30068 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: Ib15a7313fcd63e1ed9f2f5b349df967bc4335ec2 Gerrit-Change-Number: 30068 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Thu, 10 Nov 2022 00:24:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment