Change in libosmocore[master]: Update multiaddr helper - gerrit-log

18 Feb 2023


      Attention is currently required from: neels, laforge, fixeria, pespin.
msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/28993 )
Change subject: Update multiaddr helper
......................................................................
Patch Set 15:
(2 comments)
This change is ready for review.
File src/socket.c:
https://gerrit.osmocom.org/c/libosmocore/+/28993/comment/d50974e3_a6308368 
PS9, Line 220:
...
(assert()s also clarify to the reader the intended usage, and to coverity what to expect. […]
Done
https://gerrit.osmocom.org/c/libosmocore/+/28993/comment/b23b0bfe_d9439222 
PS9, Line 236: if (hosts[i])
...
That seems like odd side-effect to me for which I couldn't find any tests. […]
Done
-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28993
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Icef53fe4b6e51563d97a1bc48001d67679b3b6e9
Gerrit-Change-Number: 28993
Gerrit-PatchSet: 15
Gerrit-Owner: msuraev msuraev@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria vyanitskiy@sysmocom.de
Gerrit-Reviewer: laforge laforge@osmocom.org
Gerrit-Reviewer: neels nhofmeyr@sysmocom.de
Gerrit-Reviewer: pespin pespin@sysmocom.de
Gerrit-Attention: neels nhofmeyr@sysmocom.de
Gerrit-Attention: laforge laforge@osmocom.org
Gerrit-Attention: fixeria vyanitskiy@sysmocom.de
Gerrit-Attention: pespin pespin@sysmocom.de
Gerrit-Comment-Date: Sat, 18 Feb 2023 17:22:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels nhofmeyr@sysmocom.de
Comment-In-Reply-To: fixeria vyanitskiy@sysmocom.de
Comment-In-Reply-To: msuraev msuraev@sysmocom.de
Gerrit-MessageType: comment