pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-cbc/+/28715 ) Change subject: cbc_vty: use install_element[_ve](), not install_lib_element[_ve]() ...................................................................... cbc_vty: use install_element[_ve](), not install_lib_element[_ve]() As the naming suggests, install_lib_element[_ve]() should be used for commands registered by libraries. This API allows to enforce some rules for command attribute letters and should not be used by application specific commands. Change-Id: I8c0c8ac66dfc4fc2b8bf9102fba0df2dd988e7c9 --- M src/cbc_vty.c 1 file changed, 23 insertions(+), 23 deletions(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/src/cbc_vty.c b/src/cbc_vty.c index 9f2c073..36d646d 100644 --- a/src/cbc_vty.c +++ b/src/cbc_vty.c @@ -671,38 +671,38 @@ void cbc_vty_init(void) { - install_lib_element_ve(&show_peers_cmd); - install_lib_element_ve(&show_message_cbs_cmd); - install_lib_element_ve(&show_messages_cbs_cmd); - install_lib_element_ve(&show_messages_etws_cmd); + install_element_ve(&show_peers_cmd); + install_element_ve(&show_message_cbs_cmd); + install_element_ve(&show_messages_cbs_cmd); + install_element_ve(&show_messages_etws_cmd); - install_lib_element(CONFIG_NODE, &cfg_cbc_cmd); + install_element(CONFIG_NODE, &cfg_cbc_cmd); install_node(&cbc_node, config_write_cbc); - install_lib_element(CBC_NODE, &cfg_permit_unknown_peers_cmd); + install_element(CBC_NODE, &cfg_permit_unknown_peers_cmd); - install_lib_element(CBC_NODE, &cfg_cbsp_cmd); + install_element(CBC_NODE, &cfg_cbsp_cmd); install_node(&cbsp_node, NULL); - install_lib_element(CBSP_NODE, &cfg_cbsp_local_ip_cmd); - install_lib_element(CBSP_NODE, &cfg_cbsp_local_port_cmd); + install_element(CBSP_NODE, &cfg_cbsp_local_ip_cmd); + install_element(CBSP_NODE, &cfg_cbsp_local_port_cmd); - install_lib_element(CBC_NODE, &cfg_ecbe_cmd); + install_element(CBC_NODE, &cfg_ecbe_cmd); install_node(&ecbe_node, NULL); - install_lib_element(ECBE_NODE, &cfg_ecbe_local_ip_cmd); - install_lib_element(ECBE_NODE, &cfg_ecbe_local_port_cmd); + install_element(ECBE_NODE, &cfg_ecbe_local_ip_cmd); + install_element(ECBE_NODE, &cfg_ecbe_local_port_cmd); - install_lib_element(CBC_NODE, &cfg_sbcap_cmd); + install_element(CBC_NODE, &cfg_sbcap_cmd); install_node(&sbcap_node, NULL); - install_lib_element(SBcAP_NODE, &cfg_sbcap_local_ip_cmd); - install_lib_element(SBcAP_NODE, &cfg_sbcap_no_local_ip_cmd); - install_lib_element(SBcAP_NODE, &cfg_sbcap_local_port_cmd); + install_element(SBcAP_NODE, &cfg_sbcap_local_ip_cmd); + install_element(SBcAP_NODE, &cfg_sbcap_no_local_ip_cmd); + install_element(SBcAP_NODE, &cfg_sbcap_local_port_cmd); - install_lib_element(CBC_NODE, &cfg_cbc_peer_cmd); - install_lib_element(CBC_NODE, &cfg_cbc_no_peer_cmd); + install_element(CBC_NODE, &cfg_cbc_peer_cmd); + install_element(CBC_NODE, &cfg_cbc_no_peer_cmd); install_node(&peer_node, NULL); - install_lib_element(PEER_NODE, &cfg_peer_proto_cmd); - install_lib_element(PEER_NODE, &cfg_peer_remote_port_cmd); - install_lib_element(PEER_NODE, &cfg_peer_no_remote_port_cmd); - install_lib_element(PEER_NODE, &cfg_peer_remote_ip_cmd); - install_lib_element(PEER_NODE, &cfg_peer_no_remote_ip_cmd); + install_element(PEER_NODE, &cfg_peer_proto_cmd); + install_element(PEER_NODE, &cfg_peer_remote_port_cmd); + install_element(PEER_NODE, &cfg_peer_no_remote_port_cmd); + install_element(PEER_NODE, &cfg_peer_remote_ip_cmd); + install_element(PEER_NODE, &cfg_peer_no_remote_ip_cmd); } -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/28715 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: I8c0c8ac66dfc4fc2b8bf9102fba0df2dd988e7c9 Gerrit-Change-Number: 28715 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged