Attention is currently required from: laforge, pespin.
daniel has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/33497 )
Change subject: osmo_io: Add osmo_iofd_notify_connected()
......................................................................
Patch Set 4:
(2 comments)
Patchset:
PS3:
commitlog cold indicate the removal of the
*{write,read}_{enable,disable} exported symbols.
It's a separate commit now
PS3:
how are unconnected sockets write_enabled() now?
It already happens through the txqueue which handles en-/disabling write if it's
empty/non-empty.
I'm also enabling it now on register() if the txqueue already contains an entry.
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/33497
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ieed10bc94c8aad821c0a8f7764db0e05c054c1e3
Gerrit-Change-Number: 33497
Gerrit-PatchSet: 4
Gerrit-Owner: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 30 Jun 2023 11:59:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment