laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/26455 ) Change subject: ipaccess.c: register RSL/OML related osmo_fds for monitoring ...................................................................... ipaccess.c: register RSL/OML related osmo_fds for monitoring The osmo_fds used for ipaccess based E1 traffic should be registered for monitoring to get tcp_stats for all RSL/OML links. Change-Id: I42ca4e9257eee2857784dd4f5b17a83220e2be9e depends: libosmocore I64b288174ae3dd22d50a701ce7cbf9e623246479 Related: SYS#5701 --- M src/input/ipaccess.c 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/src/input/ipaccess.c b/src/input/ipaccess.c index 04b4474..dbb8b2e 100644 --- a/src/input/ipaccess.c +++ b/src/input/ipaccess.c @@ -50,6 +50,7 @@ #include <osmocom/abis/ipa.h> #include <osmocom/core/backtrace.h> #include <osmocom/gsm/ipa.h> +#include <osmocom/core/stats_tcp.h> /* global parameters of IPA input driver */ struct ipa_pars g_e1inp_ipaccess_pars; @@ -341,6 +342,7 @@ "could not register FD\n"); goto err; } + osmo_stats_tcp_osmo_fd_register(newbfd, "ipa-rsl"); e1i_ts = ipaccess_line_ts(newbfd, new_line); ipaccess_bsc_keepalive_fsm_alloc(e1i_ts, newbfd, "rsl_bsc_to_bts"); @@ -671,6 +673,7 @@ LOGP(DLINP, LOGL_ERROR, "could not register FD\n"); goto err_line; } + osmo_stats_tcp_osmo_fd_register(bfd, "ipa-oml"); update_fd_settings(line, bfd->fd); @@ -724,6 +727,8 @@ LOGP(DLINP, LOGL_ERROR, "could not register FD\n"); goto err_line; } + osmo_stats_tcp_osmo_fd_register(bfd, "ipa-rsl"); + /* Request ID. FIXME: request LOCATION, HW/SW VErsion, Unit Name, Serno */ ret = ipa_ccm_send_id_req(bfd->fd); if (ret < 0) { -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/26455 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I42ca4e9257eee2857784dd4f5b17a83220e2be9e Gerrit-Change-Number: 26455 Gerrit-PatchSet: 4 Gerrit-Owner: dexter &lt;pmaier(a)sysmocom.de&gt; Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria &lt;vyanitskiy(a)sysmocom.de&gt; Gerrit-Reviewer: laforge &lt;laforge(a)osmocom.org&gt; Gerrit-CC: pespin &lt;pespin(a)sysmocom.de&gt; Gerrit-MessageType: merged