Attention is currently required from: arehbein, daniel, pespin.
laforge has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmo-sccp/+/35070?usp=email )
Change subject: xua + ipa: Add support for I/O in OSMO_IO mode
......................................................................
Patch Set 8:
(3 comments)
File src/osmo_ss7_asp.c:
https://gerrit.osmocom.org/c/libosmo-sccp/+/35070/comment/88b498e2_08c97be9
PS3, Line 803: if (rc == 0) {
> It looks strange that we always used to got
through the above code and handle e.g. […]
Done
https://gerrit.osmocom.org/c/libosmo-sccp/+/35070/comment/05d55795_01a49b30
PS3, Line 950: if (rc == 0)
that's not possible IIRC, the API is documented to
return -EAGAIN iirc (historical reasons).
Done
https://gerrit.osmocom.org/c/libosmo-sccp/+/35070/comment/e8345562_83ad3ed5
PS3, Line 761: read xUA message from socket and process i
procces xUA message
Done
--
To view, visit
https://gerrit.osmocom.org/c/libosmo-sccp/+/35070?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Change-Id: I7d02037990f4af405839309510dc6c04e36c3369
Gerrit-Change-Number: 35070
Gerrit-PatchSet: 8
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: arehbein <arehbein(a)sysmocom.de>
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: arehbein <arehbein(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 05 Mar 2024 14:41:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: daniel <dwillmann(a)sysmocom.de>
Gerrit-MessageType: comment