Attention is currently required from: fixeria, neels, nt2mku.
falconia has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/36784?usp=email )
Change subject: gsm48_encode_bearer_cap(): omit octet 3a if only GSM-FR/GSM-HR v1 is supported
......................................................................
Patch Set 7:
(1 comment)
File tests/gsm0408/gsm0408_test.err:
https://gerrit.osmocom.org/c/libosmocore/+/36784/comment/edf9975a_1b2b8dd3
PS7, Line 4:
Except that this language (with "shall") does not actually appear anywhere in the spec, or at leas […]
Thank you @vyanitskiy@sysmocom.de for pointing this part out! I was so focused on the long set of tables in the spec that I failed to notice that little section *after* the tables... I stand corrected on my earlier assertion here, and I agree now that the patch is correct in the principal idea - let me now review the details.
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/36784?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ia09abb32a8458384151a6ae28744835ea440fc5b
Gerrit-Change-Number: 36784
Gerrit-PatchSet: 7
Gerrit-Owner: nt2mku
degrunert.web@googlemail.com
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria
vyanitskiy@sysmocom.de
Gerrit-Reviewer: neels
nhofmeyr@sysmocom.de
Gerrit-CC: falconia
falcon@freecalypso.org
Gerrit-CC: pespin
pespin@sysmocom.de
Gerrit-Attention: neels
nhofmeyr@sysmocom.de
Gerrit-Attention: nt2mku
degrunert.web@googlemail.com
Gerrit-Attention: fixeria
vyanitskiy@sysmocom.de
Gerrit-Comment-Date: Wed, 29 May 2024 06:38:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: falconia
falcon@freecalypso.org
Comment-In-Reply-To: neels
nhofmeyr@sysmocom.de
Comment-In-Reply-To: fixeria
vyanitskiy@sysmocom.de
Gerrit-MessageType: comment