Attention is currently required from: fixeria, laforge.

pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/41891?usp=email )

Change subject: logging: Make struct log_context and struct log_target private ......................................................................

Patch Set 1:

(1 comment)

Patchset:

PS1:

I assume old code (still referencing this struct and its members) will no longer compile against lib […]

Indeed. We can break this once and make it private, or keep forever trying to fit new stuff and breaking it 20x times like we did in the past.

In any case, compiling older code against this new libosmocore is quite straighforward, it only needs the new APIs introduced in the previous patch (which can easily be backported), and some small fixes in some apps (most apps don't access those members, so they are fine).

For reference, I faced I needed this fixed once I wanted to switch the current file log_target to use osmo_io so it can benefit from io_uring (https://osmocom.org/issues/6918).

I'll add a reference to this patch next time somebody submits a patch with a public struct instead of adding proper APIs :P

PD: I'm fine with merging this after a while, early before doing a new release, or even after. In any case, that means delaying osmo_io support there.