Attention is currently required from: dexter, pespin.
laforge has posted comments on this change by pespin. (
https://gerrit.osmocom.org/c/libosmo-sigtran/+/40579?usp=email )
Change subject: ss7_vty: Avoid adding route to local PC in role ASP
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
Patchset:
PS2:
adding @dexter as he wrote the original commit.
I don't understand the rationale of b4f1b2cb8bd404f08601dc8ca700b672a455846c as on the
ASP side the routing context (identiifed by a key) is the ASP-side point code and not a
remote point code.
But probably still worth to get @dexter input [and revisit SYS#5392 which apparently
prompted the original commit]
--
To view, visit
https://gerrit.osmocom.org/c/libosmo-sigtran/+/40579?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: Ic602de42e37c4579f530823bb41e0a8193ce73bb
Gerrit-Change-Number: 40579
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 04 Jul 2025 14:29:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes