Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/34081 ) Change subject: stream_srv: Increase logging level of SCTP MSG_NOTIFICATION lines ...................................................................... Patch Set 1: (1 comment) File src/stream_srv.c: https://gerrit.osmocom.org/c/libosmo-netif/+/34081/comment/010d02fa_c6bbaf85 PS1, Line 848: LOGP(DLINP, LOGL_DEBUG, "NOTIFICATI another even more critical problem of this function is that it logs no contxt whatsoever. You have no idea to which of your many sockets/associations it may relate to. This should be re-factored into something that generates the same prefix as LOGSSRV. If the function is to be shared between client + server (I think so), then one could just have a 'const char *prefix' argument and let the caller generate that prefix. -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/34081 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I0ed84cc2effb71b6ef1f6efb3f8b663c602a5a31 Gerrit-Change-Number: 34081 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sat, 05 Aug 2023 08:09:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment