osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hlr/+/30776 )
Change subject: osmo_mdns_rfc_record_decode: proper free on err ......................................................................
osmo_mdns_rfc_record_decode: proper free on err
Free the whole talloc tree of ret if we can't allocate memory for ret->rdata.
Related: OS#5821 Change-Id: Iefc89e3c75a4bf4ffee3871c7b551a2a608f7d5f --- M src/mslookup/mdns_rfc.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/76/30776/1
diff --git a/src/mslookup/mdns_rfc.c b/src/mslookup/mdns_rfc.c index 1bbc7b1..eddba30 100644 --- a/src/mslookup/mdns_rfc.c +++ b/src/mslookup/mdns_rfc.c @@ -263,7 +263,7 @@ /* rdata */ ret->rdata = talloc_memdup(ret, data + name_len + 10, ret->rdlength); if (!ret->rdata) - return NULL; + goto error;
*record_len = name_len + 10 + ret->rdlength; return ret;