pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27538 )
Change subject: SI13: Make sure egprs_supported field is always updated ......................................................................
SI13: Make sure egprs_supported field is always updated
If "bts->gprs.mode" was changed dynamically at runtime (VTY or CTRL), it could happen that the egprs_supported was kept as "1" if the dynamic change was EGPRS->GPRS.
In summary, if EGPRS support was set, it couldn't be unset until BSC was restarted.
Related: SYS#5894 Change-Id: Id2c2319044da474642c4cc710baa27cfee4fb592 --- M src/osmo-bsc/system_information.c 1 file changed, 4 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/38/27538/1
diff --git a/src/osmo-bsc/system_information.c b/src/osmo-bsc/system_information.c index 79008b5..8717bb5 100644 --- a/src/osmo-bsc/system_information.c +++ b/src/osmo-bsc/system_information.c @@ -1302,13 +1302,16 @@
switch (bts->gprs.mode) { case BTS_GPRS_EGPRS: + si_info.gprs_ind.present = 1; si13_default.cell_opts.ext_info.egprs_supported = 1; - /* fallthrough */ + break; case BTS_GPRS_GPRS: si_info.gprs_ind.present = 1; + si13_default.cell_opts.ext_info.egprs_supported = 0; break; case BTS_GPRS_NONE: si_info.gprs_ind.present = 0; + si13_default.cell_opts.ext_info.egprs_supported = 0; break; }
-
pespin