Attention is currently required from: falconia, laforge.

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32110 )

Change subject: common+trx: make uplink ECU optional ......................................................................

Patch Set 4:

(3 comments)

File src/common/vty.c:

https://gerrit.osmocom.org/c/osmo-bts/+/32110/comment/4ec1ddfd_3be4fd4a PS4, Line 809: bts->suppress_ul_ecu = false; I find it weird that you are kinda changing the boolean logic with the VTY command when using the variable "suppress_ul_ecu". In general I'd be more in favour of having an affirmative boolean "use_ul_ecu" which is set to true here and to false below.

File src/osmo-bts-trx/l1_if.c:

https://gerrit.osmocom.org/c/osmo-bts/+/32110/comment/43bfc1de_cd645c19 PS4, Line 445: if (!trx->bts->suppress_ul_ecu) if (trx->bts->use_ul_ecu)

https://gerrit.osmocom.org/c/osmo-bts/+/32110/comment/ab0d207e_7945408a PS4, Line 481: if (!trx->bts->suppress_ul_ecu) if (trx->bts->use_ul_ecu)