Attention is currently required from: falconia, laforge.

View Change

3 comments:

• File src/common/vty.c:

  • Patch Set #4, Line 809: bts->suppress_ul_ecu = false;

    I find it weird that you are kinda changing the boolean logic with the VTY command when using the variable "suppress_ul_ecu". In general I'd be more in favour of having an affirmative boolean "use_ul_ecu" which is set to true here and to false below.

• File src/osmo-bts-trx/l1_if.c:

  • Patch Set #4, Line 445: if (!trx->bts->suppress_ul_ecu)

    if (trx->bts->use_ul_ecu)

  • Patch Set #4, Line 481: if (!trx->bts->suppress_ul_ecu)

    if (trx->bts->use_ul_ecu)

To view, visit change 32110. To unsubscribe, or for help writing mail filters, visit settings.