Attention is currently required from: laforge, osmith.
pespin has posted comments on this change by pespin. (
https://gerrit.osmocom.org/c/libosmo-sigtran/+/40298?usp=email )
Change subject: sccp_scoc.c: validate success of sua_addr_parse()
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS1:
No, this 3 asserts I'm adding AFAIU are in paths
where we control the data being used, it's not the […]
Ok in the end I found
paths which were actually coming from user input on those, so I just submitted a new patch
doing what I believe are proper handling of error cases.
--
To view, visit
https://gerrit.osmocom.org/c/libosmo-sigtran/+/40298?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: I008ee6f9024247c14d986a2baba061cc12bf68ec
Gerrit-Change-Number: 40298
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Thu, 15 May 2025 18:46:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>