pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/31407 ) Change subject: rlcmac: tbf_ul: Allow sending UL data if in state FINISHED ...................................................................... rlcmac: tbf_ul: Allow sending UL data if in state FINISHED This can happen for instance if MS sent al the data but PCU didn't receive it all (some it was lost) so it can still keep asking the MS to submit data. In this case, the MS shall attempt retransmit of some unacked data. Change-Id: I2333a0a432c0c6f223bc1043ddb0d9c34842a5a3 --- M src/rlcmac/tbf_ul.c 1 file changed, 16 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/src/rlcmac/tbf_ul.c b/src/rlcmac/tbf_ul.c index 993f694..ce7ac1f 100644 --- a/src/rlcmac/tbf_ul.c +++ b/src/rlcmac/tbf_ul.c @@ -133,7 +133,8 @@ return false; st = gprs_rlcmac_tbf_ul_state(ul_tbf); - return (st == GPRS_RLCMAC_TBF_UL_ST_FLOW); + return (st == GPRS_RLCMAC_TBF_UL_ST_FLOW || + st == GPRS_RLCMAC_TBF_UL_ST_FINISHED); } static int gprs_rlcmac_ul_tbf_update_window(struct gprs_rlcmac_ul_tbf *ul_tbf, -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/31407 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I2333a0a432c0c6f223bc1043ddb0d9c34842a5a3 Gerrit-Change-Number: 31407 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged