Attention is currently required from: laforge, pespin.
dexter has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-pcu/+/31148
)
Change subject: pcu_l1_if.cpp: handle TLLI based IMMEDIATE ASSIGNMENT confirmation
......................................................................
Patch Set 2:
(1 comment)
File src/bts.cpp:
https://gerrit.osmocom.org/c/osmo-pcu/+/31148/comment/e0e0a3e2_8be76f9b
PS1, Line 718: int bts_rcv_imm_ass_cnf_dt(struct gprs_rlcmac_bts *bts, uint32_t tlli,
uint32_t fn)
agreed, it looks like they could be merged or one
could call the other.
I don't think we would win much. The problem is that one
uses gsm_pcu_if_data and the other uses gsm_pcu_if_data_cnf_dt.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-pcu/+/31148
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Icf7ca34500984239ee877ee71fd9c126b5eb3480
Gerrit-Change-Number: 31148
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 02 Feb 2023 15:01:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment