Attention is currently required from: fixeria, laforge, lynxis lazus, osmith.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36093?usp=email )
Change subject: epdg: Add tests to validate concurrent connections
......................................................................
Patch Set 2:
(1 comment)
File epdg/EPDG_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36093/comment/becfbb46_fe21…
PS2, Line 797: -> sender vc_conn
`vc_conn` is not used after assignment, so `->
sender vc_conn` can be dropped? […]
Definetly we don't want vc_conn_list[i]
there, since in "sender X", X is an output param.
I actually left the sender part on purpose so that it is easier for anybody adding new
tests to figure out how to pass a message back to the specific vc_conn.
It doesn't really harm anyway.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36093?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I842dacda56abe47afb19e951eaae746b5e8d9fe7
Gerrit-Change-Number: 36093
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Wed, 28 Feb 2024 18:08:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment