Attention is currently required from: fixeria.
pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41935?usp=email )
Change subject: bts: move as_rsl_meas_res() params to ConnHdlrPars
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
It's still inside the component because `ConnHdlrPars` is inside `ConnHdlr`. […]
Yes sure, but the main reason to have the Pars substruct is to be able to pass config at startup to the component. Those variables afaict are totally internal state which needs no setting up from the parent component, so I'd say they are fine being outside of Pars.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41935?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Iceb58bb636817afcd0fdf1eb3344d03153860a56
Gerrit-Change-Number: 41935
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria
vyanitskiy@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin
pespin@sysmocom.de
Gerrit-Attention: fixeria
vyanitskiy@sysmocom.de
Gerrit-Comment-Date: Mon, 26 Jan 2026 09:19:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria
vyanitskiy@sysmocom.de
Comment-In-Reply-To: pespin
pespin@sysmocom.de