Attention is currently required from: Hoernchen, laforge, pespin.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmo-gprs/+/32021 )
Change subject: gmm: Initial implementation of GPRS Attach
......................................................................
Patch Set 5:
(4 comments)
File libosmo-gprs-gmm.pc.in:
https://gerrit.osmocom.org/c/libosmo-gprs/+/32021/comment/109936e6_cae89e4c
PS1, Line 9: libosmo-gprs-llc
Because gmm_prim uses the llc_prim for the LLGMM API,
and it uses the struct defintiions and functio […]
So then the debian package also
needs to depend on libosmo-gprs-llc.so?
I don't see this being done.
File src/gmm/gmm_pdu.c:
https://gerrit.osmocom.org/c/libosmo-gprs/+/32021/comment/1f98a9a7_ac44d750
PS1, Line 142: 23
yeah, but this is all temporary to have some base upon
to work with.
Done
https://gerrit.osmocom.org/c/libosmo-gprs/+/32021/comment/26184476_daa3e16c
PS1, Line 147: rc = bitvec_unhex(&bv,
"171933432b37159ef98879cba28c6621e72688b198879c00");
yeah, but this is all temporary to have some base upon
to work with.
Done
https://gerrit.osmocom.org/c/libosmo-gprs/+/32021/comment/9967e532_e8528607
PS1, Line 172: msgb_put_u8(msg, sizeof(ms_net_cap_def));
I'll check.
Done
--
To view, visit
https://gerrit.osmocom.org/c/libosmo-gprs/+/32021
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-gprs
Gerrit-Branch: master
Gerrit-Change-Id: I212053b3a3f27ef7d63503c3d5ef08453b2d2056
Gerrit-Change-Number: 32021
Gerrit-PatchSet: 5
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 23 Mar 2023 12:22:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment