Attention is currently required from: dexter, laforge, lynxis lazus.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/34884?usp=email )
Change subject: pySim-shell: don't get trapped in applications without file system
......................................................................
Patch Set 4:
(2 comments)
File pySim-shell.py:
https://gerrit.osmocom.org/c/pysim/+/34884/comment/19dba537_a38a2ae9
PS4, Line 66: from pySim.ts_31_102 import ADF_USIM
: from pySi
you're importing but not using these?
https://gerrit.osmocom.org/c/pysim/+/34884/comment/98603e83_0677d53f
PS4, Line 605: parent = self._cmd.lchan.selected_file.get_selectables()[".."]
may be worth moving this into a separate function, to improve readability
--
To view, visit
https://gerrit.osmocom.org/c/pysim/+/34884?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ia2fdd65f430c07acb1afdaf265d24c6928b654e0
Gerrit-Change-Number: 34884
Gerrit-PatchSet: 4
Gerrit-Owner: dexter
pmaier@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge
laforge@osmocom.org
Gerrit-Reviewer: lynxis lazus
lynxis@fe80.eu
Gerrit-CC: fixeria
vyanitskiy@sysmocom.de
Gerrit-Attention: laforge
laforge@osmocom.org
Gerrit-Attention: lynxis lazus
lynxis@fe80.eu
Gerrit-Attention: dexter
pmaier@sysmocom.de
Gerrit-Comment-Date: Thu, 26 Oct 2023 10:17:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment