Attention is currently required from: osmith, pespin.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/docker-playground/+/27748 )
Change subject: ttcn-pgw-test: Improve osmo-uecups cfg file
......................................................................
Patch Set 1: Code-Review-1
(1 comment)
File ttcn3-pgw-test/osmo-uecups-daemon.cfg:
https://gerrit.osmocom.org/c/docker-playground/+/27748/comment/65ab8150_0f3…
PS1, Line 3: logging print extended-timestamp 1
What's the point of re-ordering stuff here? This makes it harder to read the patch. I
see you're changing the 'color' 0->1 and 'set-all' debug->info.
Please modify the existing lines without re-ordering them, thanks!
--
To view, visit
https://gerrit.osmocom.org/c/docker-playground/+/27748
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: I36bb04a388ab65aaa03a82c159a1b258886ec0d0
Gerrit-Change-Number: 27748
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 12 Apr 2022 11:35:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment