pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-netif/+/29466 )
Change subject: tests/osmo-pcap-test/osmux_test: Fix return condition check for osmux_xfrm_input() ......................................................................
tests/osmo-pcap-test/osmux_test: Fix return condition check for osmux_xfrm_input()
According to API doc and implementation, it never returns >1. Do as done in all other places where this API is used, that this check for >0.
Change-Id: If23dfecb566f590b7a898356469df6e322f57653 --- M tests/osmo-pcap-test/osmux_test.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/66/29466/1
diff --git a/tests/osmo-pcap-test/osmux_test.c b/tests/osmo-pcap-test/osmux_test.c index e6bbeb1..a1aa199 100644 --- a/tests/osmo-pcap-test/osmux_test.c +++ b/tests/osmo-pcap-test/osmux_test.c @@ -124,7 +124,7 @@ if (ccid < 0) register_ccid(rtph->ssrc);
- while ((ret = osmux_xfrm_input(&h_input, msg, ccid)) > 1) { + while ((ret = osmux_xfrm_input(&h_input, msg, ccid)) > 0) { /* batch full, deliver it */ osmux_xfrm_input_deliver(&h_input); }