Attention is currently required from: laforge. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30761 ) Change subject: isdndlc: Fix documentation ...................................................................... Patch Set 4: (7 comments) File src/core/isdnhdlc.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2897): https://gerrit.osmocom.org/c/libosmocore/+/30761/comment/b8beaacc_d30e1154 PS4, Line 100: excluding the CRC. please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2897): https://gerrit.osmocom.org/c/libosmocore/+/30761/comment/81c00346_5f33a401 PS4, Line 104: returns -OSMO_HDLC_FRAMING_ERROR. please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2897): https://gerrit.osmocom.org/c/libosmocore/+/30761/comment/8afbd40a_586206fe PS4, Line 104: returns -OSMO_HDLC_FRAMING_ERROR. Avoid multiple line dereference - prefer 'CRC.returns' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2897): https://gerrit.osmocom.org/c/libosmocore/+/30761/comment/548c4ab5_6dc553f0 PS4, Line 104: returns -OSMO_HDLC_FRAMING_ERROR. need consistent spacing around '-' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2897): https://gerrit.osmocom.org/c/libosmocore/+/30761/comment/f329879c_1b951bca PS4, Line 105: If a CRC error is found the function returns -OSMO_HDLC_CRC_ERROR. please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2897): https://gerrit.osmocom.org/c/libosmocore/+/30761/comment/1d937146_d501f561 PS4, Line 105: If a CRC error is found the function returns -OSMO_HDLC_CRC_ERROR. Avoid multiple line dereference - prefer 'OSMO_HDLC_FRAMING_ERROR.If' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2897): https://gerrit.osmocom.org/c/libosmocore/+/30761/comment/3579baef_53469d6a PS4, Line 105: If a CRC error is found the function returns -OSMO_HDLC_CRC_ERROR. need consistent spacing around '-' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30761 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ib5def2ae3c79f408f2ee0bb4c20fba1437d30c64 Gerrit-Change-Number: 30761 Gerrit-PatchSet: 4 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Sat, 21 Jan 2023 21:47:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment