Attention is currently required from: arehbein.

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/33083 )

Change subject: gsm/ipa: Add segmentation callback ......................................................................

Patch Set 2:

(4 comments)

File src/gsm/ipa.c:

https://gerrit.osmocom.org/c/libosmocore/+/33083/comment/1f7b7307_ee3b9001 PS2, Line 724: if (msgb_length(msg) < sizeof(struct ipaccess_head)) cosmetic: more than one line, add curly braces please

https://gerrit.osmocom.org/c/libosmocore/+/33083/comment/7a7df876_c942c04f PS2, Line 727: struct ipaccess_head *hh const?

https://gerrit.osmocom.org/c/libosmocore/+/33083/comment/e3ffefee_1ce45dae PS2, Line 730: msg->data_len < total_len Is `msg->data_len < total_len` really an error? Given that the underlying transport is usually TCP, it's absolutely normal to receive less data than indicated in the IPA header. Am I missing something? Shouldn't we just `return -EAGAIN` here, like above?

https://gerrit.osmocom.org/c/libosmocore/+/33083/comment/78fff271_fda87906 PS2, Line 730: payload_len < 0 I doubt this is possible, because a) `size_t` unsigned, and b) neither `hh->len` nor `sizeof(*hh)` can be negative.