Attention is currently required from: pespin. jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33150 ) Change subject: Added BSC tests for terminating voice group calls ...................................................................... Patch Set 3: (3 comments) File bsc/BSC_Tests_ASCI.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33150/comment/afa8e828_4e1ba... PS1, Line 382: f_sleep(2.0);

If I don't sleep here, the test will start before the BSC has completed startup and is ready for SCC […] I added comments for that.

File bsc/BSC_Tests_ASCI.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33150/comment/f5903e0f_b7044... PS2, Line 99: var boolean uplink_busy := false;

I have the feeling these 2 uplink_busy and uplink_free can be merged into 1 bool. There is a third case where none of the UPLINK FREE / UPLINK BUSY messages were received, so i need two flags. (Maybe change that to uplink_state_busy and uplink_state_unknown?)

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33150/comment/210d73c2_f98bf... PS2, Line 454: f_sleep(2.0);

why these sleeps are being kept? Please if it's really needed, add a comment explaining why. Done

-- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33150 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6762e8adfb7d5f77df837c698ff70cd7fd715ffe Gerrit-Change-Number: 33150 Gerrit-PatchSet: 3 Gerrit-Owner: jolly <andreas@eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge@osmocom.org> Gerrit-CC: pespin <pespin@sysmocom.de> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Comment-Date: Tue, 06 Jun 2023 10:29:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: jolly <andreas@eversberg.eu> Comment-In-Reply-To: pespin <pespin@sysmocom.de> Gerrit-MessageType: comment