Attention is currently required from: arehbein.

View Change

4 comments:

• File src/gsm/ipa.c:

  • Patch Set #2, Line 724: if (msgb_length(msg) < sizeof(struct ipaccess_head))

    cosmetic: more than one line, add curly braces please

  • Patch Set #2, Line 727: struct ipaccess_head *hh

    const?

  • Patch Set #2, Line 730: msg->data_len < total_len

    Is `msg->data_len < total_len` really an error? Given that the underlying transport is usually TCP, it's absolutely normal to receive less data than indicated in the IPA header. Am I missing something? Shouldn't we just `return -EAGAIN` here, like above?

  • Patch Set #2, Line 730: payload_len < 0

    I doubt this is possible, because a) `size_t` unsigned, and b) neither `hh->len` nor `sizeof(*hh)` can be negative.

To view, visit change 33083. To unsubscribe, or for help writing mail filters, visit settings.