Jenkins Builder has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-msc/+/38490?usp=email )
Change subject: vlr: add PS support ......................................................................
Patch Set 1:
(3 comments)
File src/libvlr/vlr_lu_fsm.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-19334): https://gerrit.osmocom.org/c/osmo-msc/+/38490/comment/65a3a0e5_eede9c6e?usp=... : PS1, Line 575: static int lu_compl_vlr_timeout(struct osmo_fsm_inst *fi) { open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-19334): https://gerrit.osmocom.org/c/osmo-msc/+/38490/comment/00981ee8_5a6e83cc?usp=... : PS1, Line 588: LOGPFSML(fi, LOGL_ERROR, "LU Compl timeout %i / %i \n", fi->T, lcvp->N); unnecessary whitespace before a quoted newline
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-19334): https://gerrit.osmocom.org/c/osmo-msc/+/38490/comment/ec7fd840_c7dc1334?usp=... : PS1, Line 588: LOGPFSML(fi, LOGL_ERROR, "LU Compl timeout %i / %i \n", fi->T, lcvp->N); Use %d instead of %i