Attention is currently required from: laforge, neels, osmith, pespin.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-msc/+/35872?usp=email )
Change subject: pick up all *.vty in EXTRA_DIST
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
but also neighbor_ident.vty is present in
https://obs.osmocom.org/package/show/osmocom:master/osmo-msc even though it is missing
from Makefile.am's EXTRA_DIST
Not sure about OBS, but I don't see this file in the latest release tarball:
```
$ wget
https://downloads.osmocom.org/releases/osmo-msc/osmo-msc-1.11.1.tar.bz2
$ tar -tvf osmo-msc-1.11.1.tar.bz2 | grep neighbor_ident
-rw-r--r-- 1000/1000 2034 2023-09-29 12:19
osmo-msc-1.11.1/include/osmocom/msc/neighbor_ident.h
-rw-r--r-- 1000/1000 5080 2023-09-29 12:19
osmo-msc-1.11.1/src/libmsc/neighbor_ident.c
-rw-r--r-- 1000/1000 12514 2023-09-29 12:19
osmo-msc-1.11.1/src/libmsc/neighbor_ident_vty.c
```
Could it be that the OBS builds from `*.tar.xz` generated by `git-archive` (not by `make
dist`)?
--
To view, visit
https://gerrit.osmocom.org/c/osmo-msc/+/35872?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: Id28e020fc59b83d1b4cd0e5b72314a46bea62259
Gerrit-Change-Number: 35872
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 09 Feb 2024 15:32:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de>
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment