Attention is currently required from: fixeria.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-pcu/+/30216
)
Change subject: tbf_fsm: Move osmo_fsm_inst fi out of struct tbf_fsm_ctx
......................................................................
Patch Set 1:
(1 comment)
File src/tbf.h:
https://gerrit.osmocom.org/c/osmo-pcu/+/30216/comment/eec627d2_f4417d81
PS1, Line 260: state_fi
I am wondering why not simply *fi?
Because there
are several fi on a TBF controling different stuff. We have up to 4 of them currently. So
better prefixing it to easily identify it.
This way one can use it to referr to it "Have a look at the TBF state FSM".
--
To view, visit
https://gerrit.osmocom.org/c/osmo-pcu/+/30216
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I03e691ccf6a94431caa55653349158f5b85db017
Gerrit-Change-Number: 30216
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 18 Nov 2022 13:15:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment