Attention is currently required from: laforge.
jolly has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmo-abis/+/30448 )
Change subject: Remove mISDN header from received channel data
......................................................................
Patch Set 2:
(2 comments)
File src/input/misdn.c:
https://gerrit.osmocom.org/c/libosmo-abis/+/30448/comment/a1f2ff52_a1b32ab1
PS1, Line 459: msgb_pull(msg, MISDN_HEADER_LEN);
same here
Done
File src/input/misdn.c:
https://gerrit.osmocom.org/c/libosmo-abis/+/30448/comment/de258335_a8620e88
PS2, Line 545: msgb_pull(msg, MISDN_HEADER_LEN);
: msg->l2h = msg->data;
so tsx_read and ts_raw_read now use msg->l2h =
msgb_pull... but here it's still separate. […]
Done
--
To view, visit
https://gerrit.osmocom.org/c/libosmo-abis/+/30448
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: I37f12baa1013cd1cfc6f6531b132669071eec926
Gerrit-Change-Number: 30448
Gerrit-PatchSet: 2
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Thu, 19 Jan 2023 19:04:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: comment