Attention is currently required from: laforge, lynxis lazus.

pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmocore/+/39557?usp=email )

Change subject: gprs: define OSMO_RESERVED_RAC 0xff ......................................................................

Patch Set 1:

(1 comment)

File include/osmocom/gsm/protocol/gsm_04_08_gprs.h:

https://gerrit.osmocom.org/c/libosmocore/+/39557/comment/29623828_391ca609?u... : PS1, Line 14: #define OSMO_RESERVED_RAC 0xff

so basically pespins point would be to mark it GSM*_RESERVED_RAC instead of OSMO_RESERVED_RAC. […]

I'm actually more concerned about the comment in line 11 stating "osmocom specific". Having whatever defined prefixed as OSMO_ is fine (regardless of it being osmocom specific or not, simply for C namespacing..)