Attention is currently required from: dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26950 )

Change subject: logging: log to stdout when logging is not initialized ......................................................................

Patch Set 2:

(1 comment)

File src/logging.c:

https://gerrit.osmocom.org/c/libosmocore/+/26950/comment/8dda1680_19741fbc PS2, Line 315: * Check whether the logging framework is initialized (osmo_log_info exists) */ : int log_initialized(void) : { : if (!osmo_log_info) : return 0; : return 1; : } this is a non-inline function that does nothing else but exporting the value of an (already global, exported) variable. So rather than a simple load-and-compare, the code would call a function to then perform the load-and-compare.

I would say this should at the very least be an inline function inside the header file, or since the only two users are already macros, just check for osmo_log_info directly from those macros?