Attention is currently required from: osmith. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/32432 ) Change subject: jobs/master,gerrit: use PFCP var for osmo-hnbgw ...................................................................... Patch Set 1: -Code-Review (1 comment) File jobs/gerrit-verifications.yml: https://gerrit.osmocom.org/c/osmo-ci/+/32432/comment/883c5c4e_6ec4b0bc PS1, Line 380: (PFCP == "--disable-pfcp" && WITH_MANUALS == "0") (IMHO it should be consistent with WITH_MANUALS, i.e. WITH_PFCP = [0|1], also prevents typos in incoming $PFCP which could be *anything* in this patch) -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/32432 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I4a4e25e0c179c0d408c3728a28eb75bbfa086f48 Gerrit-Change-Number: 32432 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 25 Apr 2023 18:51:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment