[S] Change in libosmocore[master]: socket: Ensure fd is not negative in osmo_sock_get_name_buf() - gerrit-log

17 Jun 2023


      Attention is currently required from: fixeria, daniel.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/33333 )
Change subject: socket: Ensure fd is not negative in osmo_sock_get_name_buf()
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
File src/core/socket.c:
https://gerrit.osmocom.org/c/libosmocore/+/33333/comment/e2ad4a7b_9a9610f4 
PS1, Line 1553: fd < 0
...
Use `OSMO_UNLIKELY` here maybe?
not really a performance critical code path.  How often do we call this?
-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/33333
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I76727993224ef87b475c33360c24966e82e866ec
Gerrit-Change-Number: 33333
Gerrit-PatchSet: 1
Gerrit-Owner: daniel dwillmann@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria vyanitskiy@sysmocom.de
Gerrit-Reviewer: laforge laforge@osmocom.org
Gerrit-Reviewer: pespin pespin@sysmocom.de
Gerrit-Attention: fixeria vyanitskiy@sysmocom.de
Gerrit-Attention: daniel dwillmann@sysmocom.de
Gerrit-Comment-Date: Sat, 17 Jun 2023 06:07:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: fixeria vyanitskiy@sysmocom.de
Gerrit-MessageType: comment