[S] Change in osmo-gsm-manuals[master]: gsup: fix wrong ordering of IEs - gerrit-log

24 Nov 2024


      Attention is currently required from: fixeria, pespin.
lynxis lazus has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/38666?usp=email )
Change subject: gsup: fix wrong ordering of IEs
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
...
...
I think in general it makes sense to ho have the Message class prior in the message [...] […]
Wouldn't it much easier to require an ordering based on ascending IE type? This way it wouldn't require to sort them based on the message and would most likely simplify the code?
-- 
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/38666?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch: master
Gerrit-Change-Id: I5caa3101da310cddfa311d068ad889bca697b438
Gerrit-Change-Number: 38666
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria vyanitskiy@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge laforge@osmocom.org
Gerrit-Reviewer: lynxis lazus lynxis@fe80.eu
Gerrit-Reviewer: pespin pespin@sysmocom.de
Gerrit-Attention: fixeria vyanitskiy@sysmocom.de
Gerrit-Attention: pespin pespin@sysmocom.de
Gerrit-Comment-Date: Sun, 24 Nov 2024 16:47:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria vyanitskiy@sysmocom.de
Comment-In-Reply-To: pespin pespin@sysmocom.de