[L] Change in libosmo-sccp[master]: xua + ipa: Add support for I/O in OSMO_IO mode - gerrit-log

6 Mar 2024

Attention is currently required from: daniel, fixeria, laforge, pespin.

jolly has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmo-sccp/+/35070?usp=email )

Change subject: xua + ipa: Add support for I/O in OSMO_IO mode
......................................................................

Patch Set 8:

(4 comments)

File src/osmo_ss7_asp.c:

https://gerrit.osmocom.org/c/libosmo-sccp/+/35070/comment/8c8d4adb_e50d58dc 
PS3, Line 904: 		xua_cli_close_and_reconnect(conn);
...
  yeah, I think the problem is that we are not using the
disconnect_cb offered by libosmo-netif here. […] This is solved in my patchset. The
disconnect_cb will be registred. This was tested and is working.

File src/osmo_ss7_asp.c:

https://gerrit.osmocom.org/c/libosmo-sccp/+/35070/comment/818ee53d_2ecfd562 
PS8, Line 657: 				osmo_stream_cli_set_segmentation_cb(asp->client,
xua_segmentation_cb);
...
  I'm happy to rename it to xua_tcp_segemntation_cb,
which is more in line with m3ua_tcp_* names in ot […] Done

https://gerrit.osmocom.org/c/libosmo-sccp/+/35070/comment/9940b836_238cac69 
PS8, Line 663: 			osmo_stream_cli_set_read_cb2(asp->client, xua_cli_read_cb);
...
  good catch.  I didn't think of
restart/reconfigure. Done

https://gerrit.osmocom.org/c/libosmo-sccp/+/35070/comment/39aeab0f_9ca1ee85 
PS8, Line 833: 		}
...
  "@jolly is working on that" means a new
patch version solving this regression will be submitted and  […] This is solved in
my patchset. The disconnect_cb will be registred. This was tested and is working.

-- 
To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/35070?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Change-Id: I7d02037990f4af405839309510dc6c04e36c3369
Gerrit-Change-Number: 35070
Gerrit-PatchSet: 8
Gerrit-Owner: laforge &lt;laforge(a)osmocom.org&gt;
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel &lt;dwillmann(a)sysmocom.de&gt;
Gerrit-Reviewer: pespin &lt;pespin(a)sysmocom.de&gt;
Gerrit-CC: fixeria &lt;vyanitskiy(a)sysmocom.de&gt;
Gerrit-CC: jolly &lt;andreas(a)eversberg.eu&gt;
Gerrit-Attention: laforge &lt;laforge(a)osmocom.org&gt;
Gerrit-Attention: pespin &lt;pespin(a)sysmocom.de&gt;
Gerrit-Attention: fixeria &lt;vyanitskiy(a)sysmocom.de&gt;
Gerrit-Attention: daniel &lt;dwillmann(a)sysmocom.de&gt;
Gerrit-Comment-Date: Wed, 06 Mar 2024 15:14:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge &lt;laforge(a)osmocom.org&gt;
Comment-In-Reply-To: pespin &lt;pespin(a)sysmocom.de&gt;
Comment-In-Reply-To: fixeria &lt;vyanitskiy(a)sysmocom.de&gt;
Comment-In-Reply-To: daniel &lt;dwillmann(a)sysmocom.de&gt;
Gerrit-MessageType: comment