Attention is currently required from: daniel, fixeria, laforge, pespin.

View Change

4 comments:

• File src/osmo_ss7_asp.c:

  • Patch Set #3, Line 904: xua_cli_close_and_reconnect(conn);

    yeah, I think the problem is that we are not using the disconnect_cb offered by libosmo-netif here. […]

    This is solved in my patchset. The disconnect_cb will be registred. This was tested and is working.

• File src/osmo_ss7_asp.c:

  • Patch Set #8, Line 657: osmo_stream_cli_set_segmentation_cb(asp->client, xua_segmentation_cb);

    I'm happy to rename it to xua_tcp_segemntation_cb, which is more in line with m3ua_tcp_* names in ot […]

    Done

  • Patch Set #8, Line 663: osmo_stream_cli_set_read_cb2(asp->client, xua_cli_read_cb);

    good catch. I didn't think of restart/reconfigure.

    Done

  • Patch Set #8, Line 833: }

    "@jolly is working on that" means a new patch version solving this regression will be submitted and […]

    This is solved in my patchset. The disconnect_cb will be registred. This was tested and is working.

To view, visit change 35070. To unsubscribe, or for help writing mail filters, visit settings.