Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/29695 ) Change subject: msc_a,vlr: add ciphering_required (accurately named) ...................................................................... Patch Set 2: Code-Review+1 (1 comment) File src/libvlr/vlr_access_req_fsm.c: https://gerrit.osmocom.org/c/osmo-msc/+/29695/comment/9aa56d34_5288d995 PS2, Line 650: if (ciphering_required) In case of assertion having the string "(!try_ciphering && ciphering_required)" like I suggested is much more informative IMHO, but fine anyway. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/29695 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I52090c5f5db997030da7c2ed9beca9c51f55f4cf Gerrit-Change-Number: 29695 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: msuraev <msuraev(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Wed, 26 Oct 2022 16:41:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment