Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/28725 )

Change subject: Introduce APDU/TPDU trace decoder ......................................................................

Patch Set 1: Code-Review+1

(3 comments)

Patchset:

PS1: Looks good in general, nice idea!

File pySim/gsmtap.py:

https://gerrit.osmocom.org/c/pysim/+/28725/comment/4edc8505_5da03304 PS1, Line 153: Int8ub I would use Const(b'\x02') to enforce GSMTAPv2 (GSMTAP_VERSION).

File pySim/ts_31_102.py:

https://gerrit.osmocom.org/c/pysim/+/28725/comment/14119eb8_c837b440 PS1, Line 303: # 3gPP TS 31.102 Section 7.5.2.1 unrelated?