Attention is currently required from: pespin, fixeria, dexter.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/30523 )
Change subject: l1sap: Accept RFC5993 and TS 101.318 HR GSM payload
......................................................................
Patch Set 4:
(1 comment)
File src/common/l1sap.c:
https://gerrit.osmocom.org/c/osmo-bts/+/30523/comment/d651df57_f43007df
PS3, Line 1915: * reception depending on what the particular BTS model supports. In case no preference is set, it will be
Better setting one than leaving it "who knows". […]
agreeing with pespin. osmo-bts-octphy is unmaintained, nobody knows if it works at all.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bts/+/30523
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I17f0b546042fa333780fd2f5c315898ab0df574c
Gerrit-Change-Number: 30523
Gerrit-PatchSet: 4
Gerrit-Owner: dexter
pmaier@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria
vyanitskiy@sysmocom.de
Gerrit-CC: laforge
laforge@osmocom.org
Gerrit-CC: pespin
pespin@sysmocom.de
Gerrit-Attention: pespin
pespin@sysmocom.de
Gerrit-Attention: fixeria
vyanitskiy@sysmocom.de
Gerrit-Attention: dexter
pmaier@sysmocom.de
Gerrit-Comment-Date: Tue, 13 Dec 2022 19:28:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin
pespin@sysmocom.de
Comment-In-Reply-To: dexter
pmaier@sysmocom.de
Gerrit-MessageType: comment