Attention is currently required from: jolly.
pespin has posted comments on this change by jolly. (
https://gerrit.osmocom.org/c/libosmocore/+/40492?usp=email )
Change subject: Add multiple messages buffers to io_uring read operations
......................................................................
Patch Set 8:
(2 comments)
File src/core/osmo_io.c:
https://gerrit.osmocom.org/c/libosmocore/+/40492/comment/d5db67e8_2e81ff47?… :
PS8, Line 152: talloc_steal(iofd, msg);
Is this code path meaningful/being used? Or can we absorbe the msg param above into being
allocated below with the rest?
https://gerrit.osmocom.org/c/libosmocore/+/40492/comment/d0cbc3ad_1561d2b3?… :
PS8, Line 166: * Only READ may have multiple buffers, because packets will only
be written to the first buffer. */
code indent should use tabs where possible
Please fix.
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/40492?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ic4544b8fcbad5a266db748d6864d3ae93ee06bce
Gerrit-Change-Number: 40492
Gerrit-PatchSet: 8
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Comment-Date: Tue, 29 Jul 2025 11:21:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No