Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38851?usp=email ) Change subject: testenv: build virtphy from src with --binary-repo ...................................................................... Patch Set 1: (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38851/comment/89adfc81_99d0… : PS1, Line 9: Add logic to build virtphy from source when running with --binary-repo. I'm not following here. Shouldn't we buld it when *not* using --binary-repo? AFAIU "binary-repo" means using the prebuild debian apt repo, isn't it? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38851?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I37bac8509b2601286e4feab099782f82c8338dca Gerrit-Change-Number: 38851 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 21 Nov 2024 12:37:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No