Attention is currently required from: pespin.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-hlr/+/31785 )
Change subject: tests/*/Makefile.am: move -I to AM_CPPFLAGS
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Pau I saw your opinion, thanks, no need to post it
again on each and every patch.
It's the matter of consistency (most project do
have `-I` in `AM_CPPFLAGS`, with some exceptions I am fixing) and clarity: `AM_CPPFLAGS`
is for preprocessor flags, `AM_CFLAGS` is for compiler flags. The fact that gcc combines
both and allows to pass arguments in arbitrary order does not mean we should put stuff in
wrong variables.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-hlr/+/31785
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Change-Id: I654053e11b0cc824c198f68e4ff0a0fcb295efb0
Gerrit-Change-Number: 31785
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 09 Mar 2023 10:58:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment