[M] Change in osmo-msc[master]: ASCI: rtp_stream_commit(): Also update MGW on conn mode change - gerrit-log

5 Jul 2023


      Attention is currently required from: jolly, laforge.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/33499 )
Change subject: ASCI: rtp_stream_commit(): Also update MGW on conn mode change
......................................................................
Patch Set 6:
(1 comment)
File src/libmsc/rtp_stream.c:
https://gerrit.osmocom.org/c/osmo-msc/+/33499/comment/1ea2c63b_af3ff28d 
PS6, Line 441: 	rtps->mode_sent_to_mgw = false;
imho this should only be set if "rtps->crcx_conn_mode != mode", aka new mode different than old mode.
-- 
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/33499
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I7a5637d0a7f1df13133e522fc78ba75eeeb2873e
Gerrit-Change-Number: 33499
Gerrit-PatchSet: 6
Gerrit-Owner: jolly andreas@eversberg.eu
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge laforge@osmocom.org
Gerrit-CC: neels nhofmeyr@sysmocom.de
Gerrit-CC: pespin pespin@sysmocom.de
Gerrit-Attention: jolly andreas@eversberg.eu
Gerrit-Attention: laforge laforge@osmocom.org
Gerrit-Comment-Date: Wed, 05 Jul 2023 10:49:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment