Attention is currently required from: msuraev. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/30684 ) Change subject: SMPP: use proper type for boolean variables ...................................................................... Patch Set 1: Code-Review-2 (1 comment) Patchset: PS1: I'm happy that you use bool, but don't merge those into a single line. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/30684 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I033a2c863213a44f99827ef997f541a7a77f5d8a Gerrit-Change-Number: 30684 Gerrit-PatchSet: 1 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Mon, 19 Dec 2022 10:33:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment