Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/29864 )

Change subject: mgw: rx_rtp(): reorder checks and handlings ......................................................................

Patch Set 1:

(2 comments)

Commit Message:

https://gerrit.osmocom.org/c/osmo-mgw/+/29864/comment/eb02d7fe_024e9ac0 PS1, Line 9: Let's first validate the origin of the message, then the content of the

(you're using "Let's" regularly, but from https://osmocom. […]

I'd say the imperative form is specially useful in the first line since it needs to be short. But if this really annoys you I'll change it.

Patchset:

PS1:

I am missing the point of the patch, can you explain the motivation / the effects in the commit log?

The motivation is explained in the commit log already. It makes sense to first look at the origin of the message before even start looking at its content, to avoid unexpected senders sending us potentially bad data which may cause some trouble in the app while parsing it.