[S] Change in osmo-ttcn3-hacks[master]: library/gsup: fix wrong IE order in f_gen_tr_ss_ies - gerrit-log

6 Nov 2024


      Attention is currently required from: fixeria, laforge, lynxis lazus.
pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38586?usp=email )
Change subject: library/gsup: fix wrong IE order in f_gen_tr_ss_ies
......................................................................
Patch Set 3:
(1 comment)
File library/GSUP_Templates.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38586/comment/a2082fb0_da580... :
PS2, Line 1412: 	ies[idx] := *;
...
well, the comment says something about a specific IE type (OSMO_GSUP_MESSAGE_CLASS_IE) while the act […]
Can't we do "(tr_GSUP_MSG_CLASS(?), omit)" or similar here?
-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38586?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I5aafbc885d3b78fd37f84feebf5dab1255d51eb1
Gerrit-Change-Number: 38586
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria vyanitskiy@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: lynxis lazus lynxis@fe80.eu
Gerrit-CC: laforge laforge@osmocom.org
Gerrit-CC: pespin pespin@sysmocom.de
Gerrit-Attention: laforge laforge@osmocom.org
Gerrit-Attention: fixeria vyanitskiy@sysmocom.de
Gerrit-Attention: lynxis lazus lynxis@fe80.eu
Gerrit-Comment-Date: Wed, 06 Nov 2024 16:00:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge laforge@osmocom.org