Attention is currently required from: pespin, fixeria.
osmith has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27260 )
Change subject: bsc_nat_fsm: initial conn-oriented forwarding
......................................................................
Patch Set 2:
(1 comment)
File src/osmo-bsc-nat/bsc_nat_fsm.c:
https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27260/comment/c348e7f7_5e915384
PS2, Line 82: return 1;
Do you really need to return 1 here? isn't 0
enough? I wouldn't complicate function signatures for n […]
ACK, fixed.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27260
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc-nat
Gerrit-Branch: master
Gerrit-Change-Id: I3df79e4dfaa60f4fd098961ee57cda71e9773b82
Gerrit-Change-Number: 27260
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 21 Feb 2022 09:34:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment