pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/29570 )

Change subject: osmux: Log remote address upon rx of osmux pkt ......................................................................

osmux: Log remote address upon rx of osmux pkt

Change-Id: Ie2a375711c7c0989161ae651ea6f0695799e2670 --- M src/libosmo-mgcp/mgcp_osmux.c 1 file changed, 6 insertions(+), 3 deletions(-)

Approvals: laforge: Looks good to me, but someone else must approve osmith: Looks good to me, but someone else must approve pespin: Looks good to me, approved Jenkins Builder: Verified

diff --git a/src/libosmo-mgcp/mgcp_osmux.c b/src/libosmo-mgcp/mgcp_osmux.c index 8b12533..aae9579 100644 --- a/src/libosmo-mgcp/mgcp_osmux.c +++ b/src/libosmo-mgcp/mgcp_osmux.c @@ -410,16 +410,19 @@ uint32_t rem; struct mgcp_trunk *trunk = ofd->data; struct rate_ctr_group *all_rtp_stats = trunk->ratectr.all_osmux_conn_stats; + char addr_str[64];

msg = osmux_recv(ofd, &rem_addr); if (!msg) return -1;

rate_ctr_inc(rate_ctr_group_get_ctr(all_rtp_stats, OSMUX_PACKETS_RX_CTR)); + osmo_sockaddr_to_str_buf(addr_str, sizeof(addr_str), &rem_addr);

if (trunk->cfg->osmux_use == OSMUX_USAGE_OFF) { LOGP(DOSMUX, LOGL_ERROR, - "bsc-nat wants to use Osmux but bsc did not request it\n"); + "Peer %s wants to use Osmux but MGCP Client did not request it\n", + addr_str); goto out; }

@@ -435,8 +438,8 @@ &rem_addr); if (!conn_src) { LOGP(DOSMUX, LOGL_DEBUG, - "Cannot find a src conn for circuit_id=%d\n", - osmuxh->circuit_id); + "Cannot find a src conn for %s CID=%d\n", + addr_str, osmuxh->circuit_id); rem = msg->len; continue; }